cap the normalized path cache #24351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @LukasReschke, @PVince81 and @butonic to be potential reviewers |
|
👍 |
|
Thanks 👍 |
|
The original issue was filed against 8.2.2 - @cmonteroluque @PVince81 @DeepDiver1975 What about the backport? |
|
The capped memory cache was backported to 8.2.4 at least. |
|
A backport should be fine but would need good regression testing, since this affects a core element. CC @karlitschek |
|
@PVince81 I completely agree. 👍 |
|
@icewind1991 Please prepare the backport PRs after the maintenance releases are out. |
This was referenced May 2, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24340
Improves memory usage for requests that handle a lot of paths (file scanner)
cc @PVince81 @DeepDiver1975